hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Fix linking issues

Browse Source 
There were linking issues, most likely because we were
applying the sanitizer flags to unnecessary targets that
are part of the build. Now, we only focus on adding the
compiler flags to lmmsobjs as a PUBLIC dependency,
and selectively choose what targets we need to apply
the linker flags to as PRIVATE dependencies.
This commit is contained in:
sakertooth
2023-09-03 02:51:14 -04:00
parent a2921a1ad6
commit c7b82f2e0e
1 changed files with 23 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
CMakeLists.txt
View File

@@ -568,21 +568,6 @@ ELSE()
SET (STATUS_DEBUG_FPE "Disabled")
ENDIF(WANT_DEBUG_FPE)
if(WANT_DEBUG_ASAN)
add_compile_options(-fsanitize=address)
add_link_options(-fsanitize=address)
endif()
if(WANT_DEBUG_TSAN)
add_compile_options(-fsanitize=thread)
add_link_options(-fsanitize=thread)
endif()
if(WANT_DEBUG_MSAN)
add_compile_options(-fsanitize=memory -fno-omit-frame-pointer)
add_link_options(-fsanitize=memory -fno-omit-frame-pointer)
endif()
# check for libsamplerate
FIND_PACKAGE(Samplerate 0.1.8 MODULE REQUIRED)
@@ -735,6 +720,29 @@ ADD_CUSTOM_TARGET(uninstall
COMMAND ${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX="${CMAKE_INSTALL_PREFIX}" -P "${CMAKE_CURRENT_SOURCE_DIR}/cmake/uninstall.cmake"
)
#
# add enabled sanitizers
# todo: use target_link_options(lmmsobjs INTERFACE -fsanitize=<check>) instead
# once support is added to link object libraries to other targets (CMake 3.12)
#
if(WANT_DEBUG_ASAN)
target_compile_options(lmmsobjs PUBLIC -fsanitize=address)
target_link_options(lmms PRIVATE -fsanitize=address)
target_link_options(tests PRIVATE -fsanitize=address)
endif()
if(WANT_DEBUG_TSAN)
target_compile_options(lmmsobjs PUBLIC -fsanitize=thread)
target_link_options(lmms PRIVATE -fsanitize=thread)
target_link_options(tests PRIVATE -fsanitize=thread)
endif()
if(WANT_DEBUG_MSAN)
target_compile_options(lmmsobjs PUBLIC -fsanitize=memory -fno-omit-frame-pointer)
target_link_options(lmms PRIVATE -fsanitize=memory -fno-omit-frame-pointer)
target_link_options(tests PRIVATE -fsanitize=memory -fno-omit-frame-pointer)
endif()
#
# display configuration information