hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

EffectSelectDialog: sort effect keys instead of plugin names

Browse Source 
Commit 360bfe5089 broke mapping between
displayed and internal effect list. Fix this by sorting the effect key
list itself.
This commit is contained in:
Tobias Doerffel
2014-02-23 17:34:40 +01:00
parent ed973bd8be
commit dd1a227963
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/gui/EffectSelectDialog.cpp
View File

@@ -44,6 +44,8 @@ EffectSelectDialog::EffectSelectDialog( QWidget * _parent ) :
// query effects
Plugin::getDescriptorsOfAvailPlugins( m_pluginDescriptors );
EffectKeyList subPluginEffectKeys;
for( Plugin::DescriptorList::ConstIterator it = m_pluginDescriptors.begin();
it != m_pluginDescriptors.end(); ++it )
{
@@ -60,7 +62,7 @@ EffectSelectDialog::EffectSelectDialog( QWidget * _parent ) :
// so we're on the safe side and the compiler
// likely will reduce that to just "it"
&( *it ),
m_effectKeys );
subPluginEffectKeys );
}
else
{
@@ -69,14 +71,15 @@ EffectSelectDialog::EffectSelectDialog( QWidget * _parent ) :
}
}
m_effectKeys += subPluginEffectKeys;
// and fill our source model
QStringList pluginNames;
QStringList subPluginNames;
for( EffectKeyList::ConstIterator it = m_effectKeys.begin(); it != m_effectKeys.end(); ++it )
{
if( ( *it ).desc->subPluginFeatures )
{
subPluginNames += QString( "%1: %2" ).arg( ( *it ).desc->displayName, ( *it ).name );
pluginNames += QString( "%1: %2" ).arg( ( *it ).desc->displayName, ( *it ).name );
}
else
{
@@ -84,11 +87,6 @@ EffectSelectDialog::EffectSelectDialog( QWidget * _parent ) :
}
}
qSort( pluginNames );
qSort( subPluginNames );
pluginNames += subPluginNames;
int row = 0;
for( QStringList::ConstIterator it = pluginNames.begin();
it != pluginNames.end(); ++it )