Fastigium
82055a9bdd
Use deleteLater() on the FxLine when deleting a channel to prevent a crash
...
In Qt, it is not safe to delete a QObject inside a signal emitted by that
QObject. This happened with FxLine when removing an FX channel using the
context menu. This commit changes that by using deleteLater() instead of
delete on the FxLine. It also hides the FxLine to prevent a ghost of it
being drawn when deleting the last non-master FX channel.
2016-03-17 19:14:52 +01:00
Fastigium
32b7e0418b
Fix two crashes when deleting FX channels
...
Lock the mixer before performing a channel delete to prevent any race
conditions causing a crash. Also, update the audioport FX channel when
an InstrumentTrack's FX channel is changed to prevent the audioport
mixing to a nonexistent channel.
2016-03-17 19:14:11 +01:00
Fastigium
9e98a16a8a
Merge pull request #2669 from Fastigium/foreach2for
...
Replace every use of the foreach macro with a C++11 range-based for loop
2016-03-14 14:15:57 +01:00
Fastigium
3c7bfbac64
Replace every use of the foreach macro with a C++11 range-based for loop
...
This prevents a race condition with Qt5. A foreach loop makes a copy of its
Qt container, increasing the reference count to the container's internal
data. Qt5 often asserts isDetached(), which requires the reference count to
be <= 1. This assertion fails when the foreach loop increases the reference
count at exactly the wrong moment. Using a range-based for loop prevents an
unnecessary copy from being made and ensures this race condition isn't
triggered.
2016-03-13 16:09:50 +01:00
Fastigium
ac67f2adb8
Compile several plugins with -std=c++0x to support range-based for loops
2016-03-13 16:09:50 +01:00
Fastigium
bfa83da572
Make lb302 include math.h so we can switch it to C++11
...
M_PI is no longer defined by default in C++11, but lb302.cpp needs it.
Therefore, before switching to C++11, we add an include.
2016-03-13 16:08:47 +01:00
Oskar Wallgren
fadba1b93c
Merge pull request #2665 from zonkmachine/filebrowser
...
File browser. Factory files off by one
2016-03-11 20:27:36 +01:00
Oskar Wallgren
311b28cf71
File browser, factory files off by one
2016-03-11 10:30:43 +01:00
Fastigium
08847cc7d3
Merge pull request #2661 from Umcaruje/bbupdate
...
Fix regression caused by fcec8dd
2016-03-10 17:26:21 +01:00
Umcaruje
6a10cb184d
Fix regression caused by fcec8dd
2016-03-10 16:06:59 +01:00
Lukas W
1f32fdcf35
Merge pull request #2654 from StCyr/StCyr_issue2653
...
ProjectVersion tests never fail
2016-03-10 09:45:48 +13:00
Umcaruje
9932da5a66
Merge pull request #2655 from Umcaruje/bbupdate
...
Fix BBtrack updating; Fix the Pattern tooltip
2016-03-09 18:57:08 +01:00
Umcaruje
fcec8ddd02
Fix BBtrack updating; Fix the Pattern tooltip
2016-03-09 16:59:19 +01:00
Cyrille Bollu
3f6f266a46
Rewrote ProjectVersionTest.cpp to use QVERIFY and indeed fail when it's supposed to fail,
...
and added 2 tests in this test suite.
2016-03-09 11:58:15 +01:00
Tres Finocchiaro
a895e2b060
Merge pull request #2652 from AOSC-Dev/master
...
data/locale: zh_CN.ts not zh.ts
2016-03-09 02:18:12 -05:00
Mingcong Bai
9ab18f5ae8
data/locale: zh_CN.ts not zh.ts
2016-03-08 16:41:45 -07:00
Tres Finocchiaro
ef2cb53282
White-space formatting
2016-03-08 13:12:00 -05:00
Tres Finocchiaro
c3abe3a69d
Add gig player to win32 builds
...
Gig player was missing a dll during the package process. This fixes it.
2016-03-08 13:10:57 -05:00
Tres Finocchiaro
515ada6102
Merge pull request #2648 from liushuyu/master
...
Update Chinese translations
2016-03-08 10:38:57 -05:00
liushuyu
a8f65ab0af
Update Chinese translations
...
Progress: 1635 of 2627 strings (62.24%)
2016-03-08 17:14:35 +08:00
Tres Finocchiaro
80b0d529b9
Merge pull request #2647 from tresf/master
...
Fix locale generation for win32 builds
2016-03-07 22:05:34 -05:00
tresf
5e4f2190a9
Fix locale generation for win32 builds
...
Closes #2577
2016-03-07 01:02:47 -05:00
Tres Finocchiaro
ba7816bda1
Merge pull request #2645 from tresf/master
...
Disable libsoundio for win32
2016-03-07 00:56:44 -05:00
Tres Finocchiaro
ac59d794fb
Disable libsoundio for win32
...
Closes #2576
2016-03-06 23:25:24 -05:00
Lukas W
8768769450
Fix channel indicator being on by default
2016-03-07 09:52:22 +13:00
Tres Finocchiaro
44f688e285
Merge pull request #2642 from michaelgregorius/2624-controller-crash
...
Fixes #2624 ("Controls window of LFO controller is not destroyed upon closing a project")
2016-03-06 13:56:09 -05:00
Michael Gregorius
1f39b607ba
Fixes #2624 ("Controls window of LFO controller is not destroyed upon
...
closing a project")
When it is destroyed the ControllerView now deletes the controller sub
window in case it has one.
2016-03-06 19:04:51 +01:00
Michael Gregorius
2e2abdf0b7
Merge pull request #2579 from michaelgregorius/performance
...
Fixes several performance problems found with Valgrind
2016-03-06 18:48:40 +01:00
Michael Gregorius
f6317f126b
Performance fixes
...
Removes some repeated calls to Qt's font layouting by using QStaticText
in FxLine and removing the overridden method ComboBox::sizeHint.
Unifies Mixer::peakValueLeft and Mixer::peakValueRight into
Mixer::getPeakValues so the array is only iterated once.
2016-03-06 18:23:35 +01:00
Tres Finocchiaro
8928ad751c
Merge pull request #2641 from Fastigium/fxsends
...
Fix regression that caused faulty FX channel index numbers
2016-03-06 12:05:10 -05:00
Fastigium
9ff8091db3
Fix regression that caused faulty FX channel index numbers
...
Commit e919912 changed the behavior of the FX channel swapping code so that
it no longer updated the m_channelIndex member of the swapped channels. This
caused sends/receives of swapped FX channels to move about when a project
was saved and loaded again.
2016-03-06 15:57:25 +01:00
Fastigium
eefefdea6f
Merge pull request #2626 from Fastigium/m_playHandlesToRemove
...
Synchronize access to Mixer::m_playHandlesToRemove
Fixes #2610
2016-03-06 15:30:08 +01:00
Umcaruje
d098a39c76
Fix dropdown menu icon margin
2016-03-04 22:10:55 +01:00
tresf
1058ea4b3f
Hide splash screen before showing settings screen
...
Per #2611
2016-03-04 14:37:12 -05:00
Tres Finocchiaro
5f48d1c596
Fix menu bar colors for Qt5
...
Per #2611
2016-03-04 13:44:54 -05:00
Tres Finocchiaro
76bd1811ae
Merge pull request #2632 from liushuyu/master
...
Change link method of Vestige module
2016-03-04 13:25:05 -05:00
liushuyu
3974faca50
Change link method of Vestige module
...
Try to fix #2628
2016-03-05 00:05:22 +08:00
Umcaruje
020b4dd1b5
Merge pull request #2574 from Umcaruje/gradients
...
Refactor the drawing of TCO's; Get rid of hardcoded colors in TCOs; Even out the color scheme
2016-03-03 09:22:12 +01:00
Lukas W
988b788608
Try fixing linker errors on Win & Mac
2016-03-03 18:43:16 +13:00
Lukas W
85011cdcf7
Move CMake locale generation from src/ to data/locale/
2016-03-03 17:37:41 +13:00
Lukas W
12e7262e98
Add missing Q_OBJECT macros
2016-03-03 17:36:38 +13:00
Umcaruje
f136ba3097
Refactor the drawing of TCO's; Get rid of hardcoded colors in TCOs; Make TCO gradient configurable; Even out the color scheme
...
Thanks to @Fastigium for helping with the BB Pattern redraw problem
2016-03-02 21:58:27 +01:00
Tres Finocchiaro
ec6734b968
Merge pull request #2629 from tresf/master
...
valgrind: init m_scrollArea in vestige instrument
2016-03-02 14:50:56 -05:00
Tres Finocchiaro
e13ac40544
valgrind: init m_scrollArea in vestige instrument
...
Closes #2041
2016-03-02 11:49:04 -05:00
Fastigium
60038b5f55
Synchronize access to Mixer::m_playHandlesToRemove
...
Put every access to m_playHandlesToRemove between lockPlayHandleRemoval() and
unlockPlayHandleRemoval(). Fixes #2610 where a SIGSEGV would occur due to
concurrent access.
2016-03-02 09:47:24 +01:00
Oskar Wallgren
346980329b
Merge pull request #2568 from zonkmachine/autosavetimeconfigrebase
...
Auto save timer setting
2016-03-02 08:54:02 +01:00
Oskar Wallgren
cfb2c7201f
Auto save timer setting
2016-03-02 07:25:19 +01:00
Tres Finocchiaro
adb25eccad
Merge pull request #2623 from bjalfi/RemotePlugin_shm_fixup
...
Fixup Zynaddsubfx-GUI on FreeBSD
2016-03-01 09:34:54 -05:00
Bastian Kummer
4ddaa872fb
Fixup Zynaddsubfx-GUI on FreeBSD
...
shmFifo destructor detaches shared-memory pointer before the included
semaphores are destroyed which results in a Segfault (at least on FreeBSD)
2016-03-01 13:54:20 +01:00
Umcaruje
1507e4b175
Merge pull request #2578 from ycollet/fix_2572
...
Change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase.
2016-02-29 17:34:26 +01:00