Amadeus Folego
e91991216d
Fix segfault when moving channels
...
This commit addresses a lot of issues, namely:
1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself
2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView
3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made
Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.
Fixes #1584
2015-01-23 05:35:59 -02:00
Lukas W
df9d495571
Some #include cleanups
2015-01-22 16:28:41 +01:00
Lukas W
ebd531e69f
Merge pull request #1652 from curlymorphic/821
...
proposed fix 821 Range-select in Song Editor
2015-01-22 13:16:40 +01:00
Lukas W
d41d816b57
Merge pull request #1661 from teeberg/style
...
Work on codestyle and readability
2015-01-21 14:19:45 +01:00
Lukas W
d6ff1a7086
Fix BB Editor project load
...
Closes #1621
2015-01-21 13:33:57 +01:00
Dave French
1cf9300f72
821 changed to use sockets/ slots
2015-01-21 11:55:30 +00:00
Jonas Trappenberg
52ec4722fb
Add explanation to acronym variable
2015-01-20 20:37:58 -08:00
Jonas Trappenberg
deb3e45791
More code style fixes
2015-01-20 20:26:33 -08:00
Jonas Trappenberg
8c76af1806
Remove premature optimization in float comparison
2015-01-20 20:26:11 -08:00
Jonas Trappenberg
71bab17233
Work on codestyle and readability
2015-01-19 19:54:06 -08:00
Daniel Winzen
a3e5a65957
Fix SongEditorWindow resize when a project loads
2015-01-19 15:32:16 +01:00
Dave French
b3d943920c
proposed fix 821 Range-select in Song Editor
2015-01-18 19:16:43 +00:00
Tres Finocchiaro
57876fead2
Merge pull request #1611 from curlymorphic/i760
...
Proposed fix 760 Improve search field
2015-01-15 15:03:43 -05:00
Lukas W
ebf68d57a9
ProjectVersion: Some refactoring
2015-01-15 17:27:58 +01:00
Lukas W
a18f86bde7
ProjectVersion: Clean up a bit, add a test
2015-01-15 17:27:58 +01:00
Lukas W
a52e4724cf
Some small SongEditor fixes
2015-01-15 17:27:57 +01:00
Jonas Trappenberg
7f38a51f9d
Merge remote-tracking branch 'upstream/master'
2015-01-14 21:07:36 -08:00
Lukas W
030292cbad
Merge pull request #1582 from tresf/master
...
ProjectVersion: Expose major/minor/release/build info
2015-01-14 20:26:43 +01:00
Jonas Trappenberg
d27d43ac42
Merge remote-tracking branch 'upstream/master'
2015-01-13 21:36:41 -08:00
Tres Finocchiaro
697fc4dd0f
Fix typo in comments
2015-01-13 11:50:11 -05:00
Tres Finocchiaro
17f32f344f
Better switching of comparators, char[] constructor
2015-01-13 11:38:17 -05:00
Tres Finocchiaro
260694077d
Misc ProjectVersion improvments
2015-01-13 11:35:46 -05:00
Lukas W
f640769ff0
SongEditor and BBEditor: Accept drops in toolbar
2015-01-13 17:29:19 +01:00
Jonas Trappenberg
ddfc3b3ee3
Remove redundant switch breaks.
2015-01-12 20:33:03 -08:00
Tres Finocchiaro
6e899d3993
Merge pull request #1572 from badosu/assign-instrument-to-fx-channel
...
Add "Assign to FX Channel" context button to track
2015-01-12 22:02:31 -05:00
Amadeus Folego
2eb420cb92
Add "Assign to FX Channel" context button to track
2015-01-13 00:45:48 -02:00
Tres Finocchiaro
21f5bb0b93
Merge pull request #1525 from badosu/show-errors-on-cli
...
[WIP] Refactor errors notification system
2015-01-12 21:45:23 -05:00
Amadeus Folego
edebf5d7da
Refactor loading song errors notification
2015-01-13 00:18:36 -02:00
Amadeus Folego
3dd1da4e25
Collect effects errors to show on summary window
2015-01-12 23:51:32 -02:00
Lee Avital
7da4efda0f
Implement 1429 -- move to next and previous pattern
2015-01-12 20:28:13 -05:00
Dave French
4206705ed2
Proposed fix 760 Improve search field
2015-01-12 22:10:15 +00:00
Lukas W
30bc86e2e7
Fix opening automation patterns per context menu
2015-01-12 22:45:47 +01:00
Tres Finocchiaro
8e5af67ec0
Fix typo in .cpp, remove unecessary changes
2015-01-12 01:00:02 -05:00
Tres Finocchiaro
300e44620a
Remove address for CompareType
2015-01-12 00:38:17 -05:00
Tres Finocchiaro
a363e7a16a
More comparitors
2015-01-12 00:22:50 -05:00
Tres Finocchiaro
23ed8673c1
Merge pull request #1597 from curlymorphic/i1345
...
updated 1345 Exclude tracks from master pitch
2015-01-11 18:49:32 -05:00
Lukas W
0d06ce7cdc
Merge pull request #1497 from DanWin/language
...
Add choose language option
2015-01-12 00:15:32 +01:00
Tres Finocchiaro
d0c8e7b307
Merge pull request #1593 from curlymorphic/i1345
...
Proposed fix for 1345 Exclude tracks from master pitch
2015-01-11 11:00:06 -05:00
Dave French
94ede26496
1345 redesigned Misc tab using GroupBox
2015-01-11 14:33:41 +00:00
Lukas W
56055b36b0
Merge branch 'master' into ed_refac
...
Conflicts:
src/gui/editors/PianoRoll.cpp
2015-01-11 13:25:55 +01:00
Lukas W
23dbe95e80
Stop on second space key press
2015-01-11 13:05:44 +01:00
Jonas Trappenberg
87e597510c
Minor refactorings and codestyle cleanup.
2015-01-11 00:05:25 -08:00
Dave French
83baea6605
1345 moved LedCheckBox to MISC tab
2015-01-10 19:05:40 +00:00
Dave French
af22d39612
Proposed fix for 1345 Exclude Tracks from master pitch
2015-01-10 17:11:17 +00:00
Tres Finocchiaro
afa55cae89
Merge pull request #1557 from curlymorphic/i1352
...
Proposed fix for 1352 Mk2, move the loaded instrument to the parent thre...
2015-01-10 09:40:48 -05:00
Tres Finocchiaro
86c2673398
Merge pull request #1563 from DanWin/resize-cursor
...
Don't display resize cursor for non-resizable TCOs
2015-01-10 09:32:09 -05:00
Tres Finocchiaro
e61a0d14f0
Merge pull request #1505 from curlymorphic/i1150
...
Proposed fix for 1150 Preset Browser: division between factory and user ...
2015-01-09 21:30:45 -05:00
Tres Finocchiaro
21c532adc0
Add internal support for major/minor/build comparator
2015-01-09 16:25:07 -05:00
Daniel Winzen
4a55e1c46a
Performance and other fixes
2015-01-09 20:17:07 +01:00
Amadeus Folego
d20e83e2f7
Fix exporting class for windows build
2015-01-09 04:27:18 -02:00
