Fixes for CodeFactor

Remove virtual keyword from methods that are marked as override.

Remove whitespaces that make CodeFactor unhappy. One of these fixes
includes moving the implementation of
LadspaMatrixControlDialog::isResizable into the cpp file.
This commit is contained in:
Michael Gregorius
2023-07-16 16:03:24 +02:00
parent bdb29fd54b
commit 6be07b170d
4 changed files with 9 additions and 5 deletions

View File

@@ -47,9 +47,9 @@ public:
// Define how the widget will behave in a layout
QSizePolicy sizePolicy() const;
virtual QSize minimumSizeHint() const override;
QSize minimumSizeHint() const override;
virtual QSize sizeHint() const override;
QSize sizeHint() const override;
QBrush const & getBackgroundBrush() const;
void setBackgroundBrush(QBrush const & backgroundBrush);
@@ -61,7 +61,7 @@ public:
void setTextColor(QColor const & textColor);
protected:
virtual void paintEvent(QPaintEvent *event) override;
void paintEvent(QPaintEvent *event) override;
private:
QString const m_text;

View File

@@ -52,7 +52,6 @@ class LMMS_EXPORT FloatModelEditorBase : public QWidget, public FloatModelView
void initUi( const QString & _name ); //!< to be called by ctors
public:
enum class DirectionOfManipulation
{
Vertical,

View File

@@ -79,6 +79,11 @@ LadspaMatrixControlDialog::LadspaMatrixControlDialog(LadspaControls * ladspaCont
}
}
bool LadspaMatrixControlDialog::isResizable() const
{
return true;
}
bool LadspaMatrixControlDialog::needsLinkColumn() const
{
LadspaControls * ladspaControls = getLadspaControls();

View File

@@ -51,7 +51,7 @@ class LadspaMatrixControlDialog : public EffectControlDialog
public:
LadspaMatrixControlDialog(LadspaControls* ctl);
bool isResizable() const override { return true; }
bool isResizable() const override;
private slots:
void updateEffectView(LadspaControls* ctl);