hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Set user wave, even when value is empty

Browse Source 
If the value or file is empty, I think showing a
error popup here is ideal.
This commit is contained in:
sakertooth
2023-09-27 07:19:37 -04:00
parent 73da2e1fa9
commit d41d02ad04
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/gui/instrument/EnvelopeAndLfoView.cpp
View File

@@ -323,11 +323,7 @@ void EnvelopeAndLfoView::dropEvent( QDropEvent * _de )
QString value = StringPairDrag::decodeValue( _de );
if( type == "samplefile" )
{
if (!value.isEmpty())
{
m_params->m_userWave = SampleLoader::createBufferFromFile(value);
}
m_params->m_userWave = SampleLoader::createBufferFromFile(value);
m_userLfoBtn->model()->setValue( true );
m_params->m_lfoWaveModel.setValue(static_cast<int>(EnvelopeAndLfoParameters::LfoShape::UserDefinedWave));
_de->accept();
@@ -339,13 +335,8 @@ void EnvelopeAndLfoView::dropEvent( QDropEvent * _de )
auto file = dataFile.content().
firstChildElement().firstChildElement().
firstChildElement().attribute("src");
if (!file.isEmpty())
{
auto buffer = SampleLoader::createBufferFromFile(file);
m_params->m_userWave = std::shared_ptr<const SampleBuffer>(std::move(buffer));
}
auto buffer = SampleLoader::createBufferFromFile(file);
m_params->m_userWave = std::shared_ptr<const SampleBuffer>(std::move(buffer));
m_userLfoBtn->model()->setValue( true );
m_params->m_lfoWaveModel.setValue(static_cast<int>(EnvelopeAndLfoParameters::LfoShape::UserDefinedWave));
_de->accept();