Johannes Lorenz
29a5abc30b
Fix Qt 5.15 build issues ( #5498 )
...
Add missing QPainterPath includes
2020-05-18 12:58:48 -04:00
Johannes Lorenz
737fcd3e55
JackMidi: Remove confusing warning at shutdown
...
Warning is:
```
jack_port_unregister called with an incorrect port 0
Failed to unregister jack midi output
```
2020-05-15 18:49:55 +02:00
Johannes Lorenz
e3cae80580
Audio/MidiJack: Fix invalid read: (3) of #5408
...
This atomically unsets the MidiJack reference in AudioJack right before
MidiJack is destroyed. This avoids AudioJack using a destroyed MidiJack
object.
2020-05-15 18:49:55 +02:00
Johannes Lorenz
9e9c5acc17
Audio/MidiJack: Fix invalid read: (2) of #5408
...
This patch
* makes `m_stopped` atomic
* initializes `m_stopped` correctly to `true`
* moves the initialization of `m_stopped` to the point where jack ports
are already connected
2020-05-15 18:49:55 +02:00
Johannes Lorenz
c6d60e982e
Audio/MidiJack: Fix invalid read: (1) of #5408
...
This fixes reading from jack MIDI events in case where
there are no jack MIDI events.
2020-05-15 18:49:55 +02:00
Kevin Zander
317be01012
Fix #4098 ( #5449 )
...
Fixes piano roll crashing when window is scaled too large.
2020-05-07 14:18:15 +02:00
thmueller64
56fbefc700
Fix #5461 and ensure consistent use of check gate ( #5475 )
...
* Multiple effects: Calculation of `outSum` should be after D/W mixing
* CrossoverEQ.cpp: `outSum` must be divided by frames in the end
* CrossoverEQ.cpp: don't overwrite `outSum` in for loop, but increment it
2020-05-06 11:23:40 +02:00
tresf
71b6107d9b
Remove unwarranted CXX flag
...
Per https://github.com/LMMS/lmms/pull/4080#issuecomment-623058847
2020-05-03 02:26:57 -04:00
Andreas Müller
f4f10c11fc
3rdparty/cmake: Do not reset CMAKE_C(XX)_FLAGS ( #4080 )
...
CMake 3rdparty: Do not overwrite CMAKE_C(XX)_FLAGS
Co-authored-by: tresf <tres.finocchiaro@gmail.com >
2020-05-02 16:55:06 -04:00
Oskar Wallgren
ca09b29087
Select the correct piano key for marking semitones ( #5478 )
...
When selecting a Piano Key to mark semitones in the Piano Roll we
select key from the y position of the pop-up menu and not the mouse.
Incidentally these two are most often the same as the menu builds
from the mouse y positon and down. If there is room for it. If there
is no room downward it will create the menu so the lower part of the
frame aligns with the mouse y position.
Fixed by creating a variable to hold the pressed key before creating
the menu.
2020-05-02 16:41:44 +09:00
Hyunjin Song
687870d302
AFP: fix loading start and loop points if the loop point is automated ( #5472 )
2020-04-28 14:41:11 +09:00
Hyunjin Song
1c5a3f8a36
DrumSynth: ensure correct envelope length in any sample rate ( #5467 )
2020-04-26 10:59:43 +02:00
Oskar Wallgren
149eca1ec9
Note selection: Editing values works in dialog ( #5438 )
2020-04-22 22:25:14 +02:00
Johannes Lorenz
27b1ce914b
Remove plugins/LadspaEffect/swh/ladspa-util.c ( #5451 )
...
This file contains no used code and it caused build problems, so we
remove it. Thanks to @plater for the issue report.
2020-04-22 10:35:00 +02:00
Hyunjin Song
8afa2d5412
Fix the linking method for the dummy Carla library
2020-04-04 12:06:35 +09:00
Johannes Lorenz
656eede6ba
Fix bug made in #5336
...
This removes a duplicate dataChanged() emit. Thanks to @PhysSong for the
hint.
2020-04-01 21:24:22 +02:00
Hyunjin Song
a8df120a58
STK Mallets: don't silence active notes when switching instruments
...
This also fixes the underlying noise on instrument switches.
2020-03-25 11:09:55 +09:00
Hyunjin Song
b51079e921
Use proper synchronization methods on some instrument track operations
2020-03-25 11:09:55 +09:00
Hyunjin Song
2367a62a51
Fix crashes and hangs on importing some Hydrogen drum kit songs ( #5420 )
2020-03-23 15:11:13 +09:00
Johannes Lorenz
d382d4e08b
Fix previous commit
2020-03-08 08:47:40 +01:00
Johannes Lorenz
ab8be73047
Cherry-pick from master commit 4dc26d1 ( #5413 )
2020-03-08 08:24:46 +01:00
Hyunjin Song
94431ea9de
RemoteVstPlugin: fix issues with FXP/FXB files on Windows ( #5411 )
2020-03-01 12:03:49 +09:00
Johannes Lorenz
47786865ef
Document strange bug
2020-02-25 20:40:49 +01:00
Johannes Lorenz
97a6379c6d
Update UI after linking models ( #4904 )
2020-02-25 20:40:49 +01:00
Johannes Lorenz
a0f4e50805
Fix knobs not updating vals on link ( #4904 )
2020-02-25 20:40:49 +01:00
Johannes Lorenz
534d7ca9c5
Fix doxygen comment
2020-02-25 20:40:49 +01:00
tresf
a77e592c19
Fix handling of plugin_export.h
...
Fixes error: definition is marked ‘dllimport’
Per #4813
2020-02-08 01:57:30 -05:00
Hyunjin Song
aeac24c06d
Fix a muted demo project "Greippi - Krem Kaakkuja (Second Flight Remix)"
2020-01-26 16:05:47 +09:00
Johannes Lorenz
d280b8628d
Fixes #3183 : Fix file factory delimeter position
2020-01-22 05:57:28 +01:00
Johannes Lorenz
427d779668
FileBrowser: Add helpful comments
2020-01-22 05:57:28 +01:00
Javier Serrano Polo
fd77c79cda
Switch to Xenial build environment ( #4813 )
...
* Switch to Xenial build environment
* Add Carla submodule/weak linking support, related #3963
* Fix Carla detection in AppImage, closes #5369
2020-01-17 10:55:07 -05:00
Dominic Clark
c52682dfb1
Fix stuck notes with Helm VSTi
2020-01-08 07:53:13 +01:00
Johannes Lorenz
a9640c8898
Comment-out deprecated attribute
...
It may be valid, but fails our CI
2019-12-26 18:23:52 +01:00
Hyunjin Song
11e5de3a4e
Debian: add libx11-xcb-dev as an explicit build dependency
2019-12-24 12:03:17 +09:00
Cyp
42f7e262e9
Fix scrolling direction in SongEditor due to stuck Ctrl/Shift.
2019-12-23 21:17:18 +01:00
Cyp
d849cc179c
Only filter out <>:"/\|?* while exporting tracks.
2019-12-23 20:05:26 +01:00
Hyunjin Song
4bfcc30a71
MIDI import: fix putting notes before the beginning of a pattern ( #5343 )
2019-12-23 17:33:46 +09:00
Cyp
578a9475ec
Fix invalid read in RemotePlugin::RemotePlugin() on opening the ZynAddSubFx GUI. ( #5299 )
...
Calling .toUtf8().constData() returns a pointer which is invalid at the end of the statement.
2019-11-22 22:26:00 +09:00
Hyunjin Song
a2e328e3dd
Fix crash on deleting instrument with controller connections on knobs ( #5306 )
...
Knob::friendlyUpdate() can be called after the model is deleted
due to signal-slot connections.
Adding a check for the model fixes a crash due to null pointer dereference.
2019-11-22 21:26:47 +09:00
Dominic Clark
cf4bb7b851
Fix remote plugin crash reading parameters from Grooove plugin ( #5300 )
2019-11-17 16:09:48 +00:00
Kevin Zander
a8d91b10e8
Fix vertical piano mouse click unresponsiveness
...
`PianoRoll::mouseDoubleClickEvent` wasn't forwarding the event to the base class when not acting on the event. The base class calls `mousePressEvent`.
Fixes #3005
2019-11-01 08:37:43 +01:00
Shmuel H
08c7e8e8dd
appimage: Escape $DIR to avoid word-splitting
2019-11-01 09:10:01 +02:00
Shmuel H
02980e610c
appimage: Use command -v instead of which (sc2230)
2019-11-01 09:10:01 +02:00
Shmuel H
55b65527c3
appimage: move launcher code into launch_lmms.sh.
2019-11-01 09:10:01 +02:00
Cyp
fd203c3f7b
Fix crash due to calling QWidget::move from a non-GUI thread while exporting tracks.
...
Calling via QMetaObject::invokeMethod should be thread safe.
Crash callstack:
QWidget::move
SongEditor::updatePosition
Song::stop
Song::stopExport
ProjectRenderer::run
QThreadPrivate::start
2019-10-31 17:24:13 +01:00
Oskar Wallgren
6c865c072d
Piano Roll - Fix retrigger with vol/pan sliders ( #5271 )
2019-10-29 14:01:05 +01:00
knittl
5e4e536bf0
Replace initializer list macros with delegating constructors ( #5279 )
...
Closes #5278
2019-10-27 21:17:04 +01:00
Hyunjin Song
dbf5f47149
Bump version to 1.2.1
v1.2.1
2019-10-21 09:27:12 +09:00
Raine M. Ekman
4f11cf1b23
Make SampleBuffer adjust its members when resampling
...
Fixes #5218 .
2019-10-19 22:41:51 +03:00
Oskar Wallgren
a9262b9613
Fix Organic offset glitch ( #5252 )
2019-10-19 11:40:06 +02:00